Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 1282473002: Remove listening of OMNIBOX_OPENED_URL from metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/containers/scoped_ptr_map.h" 12 #include "base/containers/scoped_ptr_map.h"
13 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
15 #include "base/threading/thread_checker.h" 15 #include "base/threading/thread_checker.h"
16 #include "chrome/browser/metrics/metrics_memory_details.h" 16 #include "chrome/browser/metrics/metrics_memory_details.h"
17 #include "components/metrics/metrics_service_client.h" 17 #include "components/metrics/metrics_service_client.h"
18 #include "components/metrics/profiler/tracking_synchronizer_observer.h" 18 #include "components/metrics/profiler/tracking_synchronizer_observer.h"
19 #include "components/omnibox/browser/omnibox_event_global_tracker.h"
19 #include "content/public/browser/notification_observer.h" 20 #include "content/public/browser/notification_observer.h"
20 #include "content/public/browser/notification_registrar.h" 21 #include "content/public/browser/notification_registrar.h"
21 22
22 class ChromeOSMetricsProvider; 23 class ChromeOSMetricsProvider;
23 class GoogleUpdateMetricsProviderWin; 24 class GoogleUpdateMetricsProviderWin;
24 class PluginMetricsProvider; 25 class PluginMetricsProvider;
25 class PrefRegistrySimple; 26 class PrefRegistrySimple;
26 class PrefService; 27 class PrefService;
27 class ProcessResourceUsage; 28 class ProcessResourceUsage;
28 29
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // user is performing work. This is useful to allow some features to sleep, 121 // user is performing work. This is useful to allow some features to sleep,
121 // until the machine becomes active, such as precluding UMA uploads unless 122 // until the machine becomes active, such as precluding UMA uploads unless
122 // there was recent activity. 123 // there was recent activity.
123 void RegisterForNotifications(); 124 void RegisterForNotifications();
124 125
125 // content::NotificationObserver: 126 // content::NotificationObserver:
126 void Observe(int type, 127 void Observe(int type,
127 const content::NotificationSource& source, 128 const content::NotificationSource& source,
128 const content::NotificationDetails& details) override; 129 const content::NotificationDetails& details) override;
129 130
131 // Called when a URL is opened from the Omnibox.
132 void OnURLOpenedFromOmnibox(OmniboxLog* log);
133
130 #if defined(OS_WIN) 134 #if defined(OS_WIN)
131 // Counts (and removes) the browser crash dump attempt signals left behind by 135 // Counts (and removes) the browser crash dump attempt signals left behind by
132 // any previous browser processes which generated a crash dump. 136 // any previous browser processes which generated a crash dump.
133 void CountBrowserCrashDumpAttempts(); 137 void CountBrowserCrashDumpAttempts();
134 #endif // OS_WIN 138 #endif // OS_WIN
135 139
136 base::ThreadChecker thread_checker_; 140 base::ThreadChecker thread_checker_;
137 141
138 // Weak pointer to the MetricsStateManager. 142 // Weak pointer to the MetricsStateManager.
139 metrics::MetricsStateManager* metrics_state_manager_; 143 metrics::MetricsStateManager* metrics_state_manager_;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 // used. 191 // used.
188 base::Callback<void(bool*)> cellular_callback_; 192 base::Callback<void(bool*)> cellular_callback_;
189 193
190 // Time of this object's creation. 194 // Time of this object's creation.
191 const base::TimeTicks start_time_; 195 const base::TimeTicks start_time_;
192 196
193 // Map of ProcessResourceUsage from render process host IDs. 197 // Map of ProcessResourceUsage from render process host IDs.
194 base::ScopedPtrMap<int, scoped_ptr<ProcessResourceUsage>> 198 base::ScopedPtrMap<int, scoped_ptr<ProcessResourceUsage>>
195 host_resource_usage_map_; 199 host_resource_usage_map_;
196 200
201 // Subscription for receiving callbacks that a URL was opened from the
202 // omnibox.
203 scoped_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription>
204 omnibox_url_opened_subscription_;
205
197 base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_; 206 base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;
198 207
199 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient); 208 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);
200 }; 209 };
201 210
202 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 211 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698