Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: chrome/browser/metrics/thread_watcher.h

Issue 1282473002: Remove listening of OMNIBOX_OPENED_URL from metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/metrics/thread_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.h
diff --git a/chrome/browser/metrics/thread_watcher.h b/chrome/browser/metrics/thread_watcher.h
index f62b04d1be4550771df2db0dbd0b630ca65223a6..457c2d681a6a5571bd402e324cccd95289d89df7 100644
--- a/chrome/browser/metrics/thread_watcher.h
+++ b/chrome/browser/metrics/thread_watcher.h
@@ -59,6 +59,7 @@
#include "base/threading/thread.h"
#include "base/threading/watchdog.h"
#include "base/time/time.h"
+#include "components/omnibox/browser/omnibox_event_global_tracker.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -532,6 +533,12 @@ class ThreadWatcherObserver : public content::NotificationObserver {
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
+ // Called when a URL is opened from the Omnibox.
+ void OnURLOpenedFromOmnibox(OmniboxLog* log);
+
+ // Called when user activity is detected.
+ void OnUserActivityDetected();
+
// The singleton of this class.
static ThreadWatcherObserver* g_thread_watcher_observer_;
@@ -544,6 +551,11 @@ class ThreadWatcherObserver : public content::NotificationObserver {
// It is the time interval between wake up calls to thread watchers.
const base::TimeDelta wakeup_interval_;
+ // Subscription for receiving callbacks that a URL was opened from the
+ // omnibox.
+ scoped_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription>
+ omnibox_url_opened_subscription_;
+
DISALLOW_COPY_AND_ASSIGN(ThreadWatcherObserver);
};
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/metrics/thread_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698