Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1282453002: [tracing] Reland of Throttle rate of heavy dumps and support to request light/heavy dumps (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
Reviewers:
nduca, Sami, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, pfeldman, tracing+reviews_chromium.org, wfh+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Reland of Throttle rate of heavy dumps and support to request light/heavy dumps Reason for revert: telemetry test failure. Fix: This CL adds the missing IPC macros for passing the struct which caused the test failure. Original message: Currently all the dump providers dump detailed dumps every periodic dump. This makes the trace files huge. So, this CL throttles down the rate of heavy dumps of all the dump providers and removes temporary hacks. Along with this, this CL also adds support to request light and heavy dumps by adding MemoryDumpArgs as param to RequestGlobalDump() TBR=pfeldman@chromium.org, nduca@chromium.org BUG=499731 Committed: https://crrev.com/33f2d3a5b276b70040adfd21edf364bd666b0aa2 Cr-Commit-Position: refs/heads/master@{#342145} patch from issue 1267963002 at patchset 80001 (http://crrev.com/1267963002#ps80001) Committed: https://crrev.com/46a37de67fddcbab4d9adc7b5ade79f582af8b93 Cr-Commit-Position: refs/heads/master@{#342436}

Patch Set 1 : ORIGINAL PATCH #

Patch Set 2 : REBASE. #

Patch Set 3 : Fix IPC messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -51 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 chunk +4 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 7 chunks +18 lines, -30 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 15 chunks +79 lines, -14 lines 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_request_args.h View 3 chunks +3 lines, -2 lines 0 comments Download
M base/trace_event/memory_dump_request_args.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
ssid
PTAL, thanks. Adds missing changes for IPC argument.
5 years, 4 months ago (2015-08-07 10:38:25 UTC) #4
Sami
Non-owner lgtm.
5 years, 4 months ago (2015-08-07 11:40:29 UTC) #5
ssid
On 2015/08/07 11:40:29, Sami wrote: > Non-owner lgtm. Thanks sami.
5 years, 4 months ago (2015-08-07 11:41:12 UTC) #6
ssid
+dcheng PTAL. This adds a field dumpArgs in the IPC message. +nduca PTAL. No changes ...
5 years, 4 months ago (2015-08-07 11:42:50 UTC) #8
dcheng
IPC changes lgtm
5 years, 4 months ago (2015-08-07 17:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282453002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282453002/80001
5 years, 4 months ago (2015-08-07 19:37:45 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 4 months ago (2015-08-07 20:50:29 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 20:51:08 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/46a37de67fddcbab4d9adc7b5ade79f582af8b93
Cr-Commit-Position: refs/heads/master@{#342436}

Powered by Google App Engine
This is Rietveld 408576698