Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275013005: [tracing] Disable memory maps dump provider for security reason (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, sullivan, mdempsky, petrcermak, Primiano Tucci (use gerrit), jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Disable memory maps dump provider for security reason The memory maps should not be exposed to untrusted renderers. So, the memory maps dump provider is disabled till the tracing infra is more secure. BUG=517906 Committed: https://crrev.com/106f089b0e23ebbe25fef13880d8ebe4902939e0 Cr-Commit-Position: refs/heads/master@{#342549}

Patch Set 1 #

Patch Set 2 : Enable for telemetry. #

Total comments: 1

Patch Set 3 : Disabling correct dumper #

Patch Set 4 : Fixing telemetry test. #

Patch Set 5 : Fixing telemetry. #

Total comments: 3

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M base/trace_event/memory_dump_manager.cc View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
ssid
Disables memory maps dump.
5 years, 4 months ago (2015-08-07 15:17:13 UTC) #2
dsinclair
https://codereview.chromium.org/1275013005/diff/20001/base/trace_event/memory_dump_manager.cc File base/trace_event/memory_dump_manager.cc (right): https://codereview.chromium.org/1275013005/diff/20001/base/trace_event/memory_dump_manager.cc#newcode126 base/trace_event/memory_dump_manager.cc:126: RegisterDumpProvider(ProcessMemoryMapsDumpProvider::GetInstance()); Don't the rest of these also need to ...
5 years, 4 months ago (2015-08-07 15:28:25 UTC) #3
ssid
Made changes, PTAL. +sievers For adding a switch in gpu process.
5 years, 4 months ago (2015-08-07 22:38:30 UTC) #5
mdempsky
https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc File base/trace_event/memory_dump_manager.cc (right): https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc#newcode125 base/trace_event/memory_dump_manager.cc:125: "enable-memory-benchmarking")) { Shouldn't this be switches::kEnableMemoryBenchmarking?
5 years, 4 months ago (2015-08-07 22:48:25 UTC) #7
ssid
https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc File base/trace_event/memory_dump_manager.cc (right): https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc#newcode125 base/trace_event/memory_dump_manager.cc:125: "enable-memory-benchmarking")) { On 2015/08/07 22:48:25, mdempsky wrote: > Shouldn't ...
5 years, 4 months ago (2015-08-07 22:58:06 UTC) #8
mdempsky
https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc File base/trace_event/memory_dump_manager.cc (right): https://codereview.chromium.org/1275013005/diff/80001/base/trace_event/memory_dump_manager.cc#newcode125 base/trace_event/memory_dump_manager.cc:125: "enable-memory-benchmarking")) { On 2015/08/07 22:58:06, ssid wrote: > actually ...
5 years, 4 months ago (2015-08-07 23:01:59 UTC) #9
no sievers
On 2015/08/07 22:38:30, ssid wrote: > Made changes, PTAL. > > +sievers For adding a ...
5 years, 4 months ago (2015-08-07 23:24:20 UTC) #10
dsinclair
lgtm
5 years, 4 months ago (2015-08-08 12:32:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275013005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275013005/80001
5 years, 4 months ago (2015-08-08 12:32:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275013005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275013005/100001
5 years, 4 months ago (2015-08-09 01:32:20 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-09 01:56:59 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-09 01:57:48 UTC) #19
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/106f089b0e23ebbe25fef13880d8ebe4902939e0
Cr-Commit-Position: refs/heads/master@{#342549}

Powered by Google App Engine
This is Rietveld 408576698