Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1266003003: [tracing] Add light dumps in the V8 dump provider (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@light_dumps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Add light dumps in the V8 dump provider This CL updates the V8 dump provider to dump only totals of the heap when a light dump is requested. BUG=499731 Committed: https://crrev.com/2888a24fd1d63a4c2afd9102d72be2f36d581ba5 Cr-Commit-Position: refs/heads/master@{#342471}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M gin/v8_isolate_memory_dump_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M gin/v8_isolate_memory_dump_provider.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
ssid
PTAL
5 years, 4 months ago (2015-08-05 10:30:43 UTC) #2
petrcermak
LGTM! Thanks, Petr
5 years, 4 months ago (2015-08-05 10:52:28 UTC) #3
petrcermak
One more nit: s/in/to the/ in the title and first line.
5 years, 4 months ago (2015-08-05 10:57:39 UTC) #4
ssid
+jochen PTAL. Small patch for V8. Thanks
5 years, 4 months ago (2015-08-07 09:37:56 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-07 09:42:05 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 1282453002 Patch 80001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-07 12:58:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003003/20001
5 years, 4 months ago (2015-08-07 23:02:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 23:08:51 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 23:09:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2888a24fd1d63a4c2afd9102d72be2f36d581ba5
Cr-Commit-Position: refs/heads/master@{#342471}

Powered by Google App Engine
This is Rietveld 408576698