Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281903002: [heap] Remove unused support for heap iterator size function. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-mark-compact-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unused support for heap iterator size function. R=hpayer@chromium.org Committed: https://crrev.com/eabb514278eef838aa8007558067194bd281b7fe Cr-Commit-Position: refs/heads/master@{#30071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -83 lines) Patch
M src/globals.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 8 chunks +5 lines, -16 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +11 lines, -40 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1278113004 Patch 1

Messages

Total messages: 8 (1 generated)
Michael Starzinger
Dead code is being dead.
5 years, 4 months ago (2015-08-07 13:00:08 UTC) #1
titzer
On 2015/08/07 13:00:08, Michael Starzinger wrote: > Dead code is being dead. lgtm
5 years, 4 months ago (2015-08-07 13:02:01 UTC) #2
Hannes Payer (out of office)
On 2015/08/07 13:02:01, titzer wrote: > On 2015/08/07 13:00:08, Michael Starzinger wrote: > > Dead ...
5 years, 4 months ago (2015-08-07 13:13:59 UTC) #3
Hannes Payer (out of office)
On 2015/08/07 13:02:01, titzer wrote: > On 2015/08/07 13:00:08, Michael Starzinger wrote: > > Dead ...
5 years, 4 months ago (2015-08-07 13:14:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281903002/1
5 years, 4 months ago (2015-08-07 13:43:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 13:46:34 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:46:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eabb514278eef838aa8007558067194bd281b7fe
Cr-Commit-Position: refs/heads/master@{#30071}

Powered by Google App Engine
This is Rietveld 408576698