Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278113004: [heap] Remove unused IntrusiveMarking class. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unused IntrusiveMarking class. R=hpayer@chromium.org Committed: https://crrev.com/56b32678d37b7b862a6e62c213a7859256325fda Cr-Commit-Position: refs/heads/master@{#30068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -70 lines) Patch
M src/heap/heap.h View 3 chunks +0 lines, -57 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1281903002 Patch 1

Messages

Total messages: 7 (1 generated)
Michael Starzinger
Dead code is being dead.
5 years, 4 months ago (2015-08-07 12:56:14 UTC) #1
titzer
On 2015/08/07 12:56:14, Michael Starzinger wrote: > Dead code is being dead. lgtm
5 years, 4 months ago (2015-08-07 13:02:17 UTC) #2
Hannes Payer (out of office)
On 2015/08/07 12:56:14, Michael Starzinger wrote: > Dead code is being dead. Lgtm lol
5 years, 4 months ago (2015-08-07 13:13:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278113004/1
5 years, 4 months ago (2015-08-07 13:17:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 13:20:08 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:20:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56b32678d37b7b862a6e62c213a7859256325fda
Cr-Commit-Position: refs/heads/master@{#30068}

Powered by Google App Engine
This is Rietveld 408576698