Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1281763002: Adds a CompareSpdyHeaderBlocks method, rather than relying on operator==. (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a CompareSpdyHeaderBlocks method, rather than relying on operator==. Soon SpdyHeaderBlock will become a LinkedHashMap which does not have operator== defined, and it doesn't look likely that it will gain such an implementation (if cl/98825772 does get submitted, I'll revert this CL). No behavior change. relnote: n/a (test only) Merge internal change: 99406076 R=rch@chromium.org Committed: https://crrev.com/c88daa5c70a8be3eae0704f15491e243fd49ce06 Cr-Commit-Position: refs/heads/master@{#342397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M net/quic/quic_headers_stream_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/spdy_balsa_utils_test.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
ramant (doing other things)
5 years, 4 months ago (2015-08-07 01:57:00 UTC) #1
Ryan Hamilton
This doesn't appear to actually add CompareSpdyHeaderBlocks, does it? I just bnc merged that part ...
5 years, 4 months ago (2015-08-07 18:37:26 UTC) #2
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-08-07 18:37:33 UTC) #3
ramant (doing other things)
On 2015/08/07 18:37:26, Ryan Hamilton wrote: > This doesn't appear to actually add CompareSpdyHeaderBlocks, does ...
5 years, 4 months ago (2015-08-07 18:40:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281763002/1
5 years, 4 months ago (2015-08-07 18:41:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 18:48:06 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:48:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c88daa5c70a8be3eae0704f15491e243fd49ce06
Cr-Commit-Position: refs/heads/master@{#342397}

Powered by Google App Engine
This is Rietveld 408576698