Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: net/tools/quic/spdy_balsa_utils_test.cc

Issue 1281763002: Adds a CompareSpdyHeaderBlocks method, rather than relying on operator==. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/spdy_balsa_utils_test.cc
diff --git a/net/tools/quic/spdy_balsa_utils_test.cc b/net/tools/quic/spdy_balsa_utils_test.cc
index 3d11c94cc19fc4bb471bc0d6dde0860f9e2228fc..fa76b4a26924802df0b6975868bbb281d74b1930 100644
--- a/net/tools/quic/spdy_balsa_utils_test.cc
+++ b/net/tools/quic/spdy_balsa_utils_test.cc
@@ -4,8 +4,11 @@
#include "net/tools/quic/spdy_balsa_utils.h"
+#include "net/spdy/spdy_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
+using net::test::CompareSpdyHeaderBlocks;
+
namespace net {
namespace tools {
namespace test {
@@ -24,7 +27,7 @@ TEST(SpdyBalsaUtilsTest, RequestHeadersToSpdyHeaders) {
expected_headers[":path"] = "/foo";
expected_headers[":scheme"] = "https";
- EXPECT_EQ(expected_headers, spdy_headers);
+ EXPECT_TRUE(CompareSpdyHeaderBlocks(expected_headers, spdy_headers));
}
TEST(SpdyBalsaUtilsTest, ResponseHeadersToSpdyHeaders) {
@@ -37,7 +40,7 @@ TEST(SpdyBalsaUtilsTest, ResponseHeadersToSpdyHeaders) {
SpdyHeaderBlock expected_headers;
expected_headers[":status"] = "200";
- EXPECT_EQ(expected_headers, spdy_headers);
+ EXPECT_TRUE(CompareSpdyHeaderBlocks(expected_headers, spdy_headers));
}
TEST(SpdyBalsaUtilsTest, SpdyHeadersToRequestHeaders) {
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698