chrome/browser/ui/startup/default_browser_prompt.cc - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/default_browser_prompt.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ninja -C out/Debug all Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugins/plugin_metadata.cc ('K') | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | components/update_client/test_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/default_browser_prompt.cc

diff --git a/chrome/browser/ui/startup/default_browser_prompt.cc b/chrome/browser/ui/startup/default_browser_prompt.cc

index e11da719ed817251652e9d3eae9a1adbcb16d6cf..329da02b9dd1e516010432b5bf8e395f9e326e73 100644

--- a/chrome/browser/ui/startup/default_browser_prompt.cc

+++ b/chrome/browser/ui/startup/default_browser_prompt.cc

@@ -267,10 +267,11 @@ void ShowDefaultBrowserPrompt(Profile* profile, HostDesktopType desktop_type) {

const std::string disable_version_string =

g_browser_process->local_state()->GetString(

prefs::kBrowserSuppressDefaultBrowserPrompt);

- const Version disable_version(disable_version_string);

+ const base::Version disable_version(disable_version_string);

DCHECK(disable_version_string.empty() || disable_version.IsValid());

if (disable_version.IsValid()) {

- if (disable_version.Equals(Version(version_info::GetVersionNumber())))

+ if (disable_version.Equals(

+ base::Version(version_info::GetVersionNumber())))

show_prompt = false;

}