components/update_client/test_installer.cc - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/test_installer.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ninja -C out/Debug all Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/update_client/test_installer.cc

diff --git a/components/update_client/test_installer.cc b/components/update_client/test_installer.cc

index ad6015b980083cba9386902bfad983e741bdbd14..21a3b2a3bed0d1ccec928601cad5fe5bdea1f999 100644

--- a/components/update_client/test_installer.cc

+++ b/components/update_client/test_installer.cc

@@ -62,7 +62,7 @@ bool VersionedTestInstaller::Install(const base::DictionaryValue& manifest,

const base::FilePath& unpack_path) {

std::string version_string;

manifest.GetStringASCII("version", &version_string);

- Version version(version_string.c_str());

+ base::Version version(version_string.c_str());

brettw 2015/08/13 18:24:35 Remove the .c_str() here since it just makes an un

base::FilePath path;

path = install_directory_.AppendASCII(version.GetString());

« chrome/browser/plugins/plugin_metadata.cc ('K') | « components/update_client/test_installer.h ('k') | components/update_client/update_client.h » ('j') | no next file with comments »