chrome/browser/profiles/profile_impl.cc - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ninja -C out/Debug all Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugins/plugin_metadata.cc ('K') | « chrome/browser/plugins/plugin_metadata_unittest.cc ('k') | chrome/browser/ui/startup/default_browser_prompt.cc » ('j') | components/update_client/test_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_impl.cc

diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc

index a0f1c787268ce8549b2519d56e367cb21a0b2e7f..9ec59bd7496c06813dd9e332090db658a2de3fa1 100644

--- a/chrome/browser/profiles/profile_impl.cc

+++ b/chrome/browser/profiles/profile_impl.cc

@@ -874,8 +874,8 @@ void ProfileImpl::OnPrefsLoaded(CreateMode create_mode, bool success) {

}

bool ProfileImpl::WasCreatedByVersionOrLater(const std::string& version) {

- Version profile_version(ChromeVersionService::GetVersion(prefs_.get()));

- Version arg_version(version);

+ base::Version profile_version(ChromeVersionService::GetVersion(prefs_.get()));

+ base::Version arg_version(version);

return (profile_version.CompareTo(arg_version) >= 0);

}