Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1280973004: Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue (Closed)

Created:
5 years, 4 months ago by Paritosh Kumar
Modified:
5 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue BUG=472381 Committed: https://crrev.com/5438a98ac376de45d277fa7ffbb65258577d0fe7 Cr-Commit-Position: refs/heads/master@{#342791}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M net/proxy/proxy_config.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 4 months ago (2015-08-10 13:08:02 UTC) #2
eroman
looks good after fixing comment https://codereview.chromium.org/1280973004/diff/1/net/proxy/proxy_config.h File net/proxy/proxy_config.h (right): https://codereview.chromium.org/1280973004/diff/1/net/proxy/proxy_config.h#newcode177 net/proxy/proxy_config.h:177: // Creates a Value ...
5 years, 4 months ago (2015-08-10 22:12:42 UTC) #3
Paritosh Kumar
On 2015/08/10 22:12:42, eroman wrote: > looks good after fixing comment > > https://codereview.chromium.org/1280973004/diff/1/net/proxy/proxy_config.h > ...
5 years, 4 months ago (2015-08-11 04:39:40 UTC) #4
eroman
lgtm
5 years, 4 months ago (2015-08-11 04:41:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280973004/20001
5 years, 4 months ago (2015-08-11 04:42:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 05:53:37 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 05:54:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5438a98ac376de45d277fa7ffbb65258577d0fe7
Cr-Commit-Position: refs/heads/master@{#342791}

Powered by Google App Engine
This is Rietveld 408576698