Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: net/proxy/proxy_config.h

Issue 1280973004: Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/proxy/proxy_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config.h
diff --git a/net/proxy/proxy_config.h b/net/proxy/proxy_config.h
index 90ac96be83ab491a71820af33aa20d157d69cc6d..303aa10b09aa7d1da82c4c77377be4d4c4ff082e 100644
--- a/net/proxy/proxy_config.h
+++ b/net/proxy/proxy_config.h
@@ -174,9 +174,8 @@ class NET_EXPORT ProxyConfig {
void ClearAutomaticSettings();
- // Creates a Value dump of this configuration. The caller is responsible for
- // deleting the returned value.
- base::DictionaryValue* ToValue() const;
+ // Creates a Value dump of this configuration.
+ scoped_ptr<base::DictionaryValue> ToValue() const;
ProxyRules& proxy_rules() {
return proxy_rules_;
« no previous file with comments | « no previous file | net/proxy/proxy_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698