Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: net/proxy/proxy_config.cc

Issue 1280973004: Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_config.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config.cc
diff --git a/net/proxy/proxy_config.cc b/net/proxy/proxy_config.cc
index a88ed63cd05a093b6e983efd712809350f20e3d1..2ac6de1b328439b85f2e04735942f460c21379c7 100644
--- a/net/proxy/proxy_config.cc
+++ b/net/proxy/proxy_config.cc
@@ -231,7 +231,7 @@ void ProxyConfig::ClearAutomaticSettings() {
pac_url_ = GURL();
}
-base::DictionaryValue* ProxyConfig::ToValue() const {
+scoped_ptr<base::DictionaryValue> ProxyConfig::ToValue() const {
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
// Output the automatic settings.
@@ -286,7 +286,7 @@ base::DictionaryValue* ProxyConfig::ToValue() const {
// Output the source.
dict->SetString("source", ProxyConfigSourceToString(source_));
- return dict.release();
+ return dict.Pass();
}
} // namespace net
« no previous file with comments | « net/proxy/proxy_config.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698