Deliver action clicks to page notifications (blink)

Source/modules/notifications/NotificationEvent.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/notifications/NotificationEvent.h"
-#include "wtf/text/WTFString.h"
 
 namespace blink {
 
-NotificationEvent::NotificationEvent()
-    : m_action(emptyString())
-{
-}
+NotificationEvent::NotificationEvent() { }
 
 NotificationEvent::NotificationEvent(const AtomicString& type, const NotificationEventInit& initializer)
     : ExtendableEvent(type, initializer)

[Peter Beverloo, 2015/08/07 07:25:25]

Use a delegated constructor w/ observer==nullptr?

-    , m_action(initializer.action())
 {
     if (initializer.hasNotification())
         m_notification = initializer.notification();
+    if (initializer.hasAction())

[Peter Beverloo, 2015/08/07 07:25:25]

You explicitly used "emptyString()" before, now we default to the empty String
constructor. Is this difference observable from Web exposed behaviour?

+        m_action = initializer.action();
 }
 
 NotificationEvent::NotificationEvent(const AtomicString& type, const NotificationEventInit& initializer, WaitUntilObserver* observer)
     : ExtendableEvent(type, initializer, observer)
-    , m_action(initializer.action())
 {
     if (initializer.hasNotification())
         m_notification = initializer.notification();
+    if (initializer.hasAction())
+        m_action = initializer.action();
 }
 
 NotificationEvent::~NotificationEvent()
 {
 }
 
 const AtomicString& NotificationEvent::interfaceName() const
 {
     return EventNames::NotificationEvent;
 }
 
 DEFINE_TRACE(NotificationEvent)
 {
     visitor->trace(m_notification);
     ExtendableEvent::trace(visitor);
 }
 
 } // namespace blink