Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1279323002: Call dispatcher's releaseRegistration when done with registrations (Closed)

Created:
5 years, 4 months ago by jkarlin
Modified:
5 years, 3 months ago
Reviewers:
jsbell, iclelland
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Call dispatcher's releaseRegistration when done with them With this series of patches, the BackgroundSyncManager expects clients to call ReleaseRegistration once no longer referencing them. This CL has Blink call releaseRegistration when the SyncRegistration and PeriodicRegistration are deleted. Patch 1 [Blink]: this Patch 2 [Browser]: https://codereview.chromium.org/1282013004 Patch 3 [Blink cleanup]: https://codereview.chromium.org/1359653002 BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200504

Patch Set 1 #

Patch Set 2 : Add trackRegistration #

Patch Set 3 : Own the WebSyncRegistration #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/modules/background_sync/PeriodicSyncRegistration.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/background_sync/SyncRegistration.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
jkarlin
iclelland: PTAL, thanks!
5 years, 4 months ago (2015-08-10 19:12:41 UTC) #2
iclelland
lgtm
5 years, 4 months ago (2015-08-12 04:10:16 UTC) #3
jkarlin
I added one more function to WebSyncProvider in PS2. Can you take another look Ian? ...
5 years, 4 months ago (2015-08-12 16:02:10 UTC) #4
jkarlin
jsbell@: PTAL for committer approval, thanks!
5 years, 4 months ago (2015-08-13 12:01:55 UTC) #6
iclelland
On 2015/08/12 16:02:10, jkarlin wrote: > I added one more function to WebSyncProvider in PS2. ...
5 years, 4 months ago (2015-08-13 12:22:54 UTC) #7
jsbell
lgtm
5 years, 4 months ago (2015-08-13 18:59:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279323002/60001
5 years, 4 months ago (2015-08-13 19:12:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/92850)
5 years, 4 months ago (2015-08-13 21:06:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279323002/60001
5 years, 4 months ago (2015-08-13 21:36:22 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200504
5 years, 4 months ago (2015-08-14 01:57:23 UTC) #16
cbiesinger
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1287343004/ by cbiesinger@chromium.org. ...
5 years, 4 months ago (2015-08-14 16:05:36 UTC) #17
jkarlin
5 years, 4 months ago (2015-08-17 11:20:09 UTC) #18
Message was sent while issue was closed.
Reland in https://codereview.chromium.org/1290073003

Powered by Google App Engine
This is Rietveld 408576698