Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1290073003: Reland Call dispatcher's releaseRegistration when done with registrations (Closed)

Created:
5 years, 4 months ago by jkarlin
Modified:
5 years, 4 months ago
Reviewers:
jsbell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland Call dispatcher's releaseRegistration when done with registrations Reland of https://codereview.chromium.org/1279323002/ OilPan objects can be garbage collected at any time, so it's necessary to check the pointers. BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200657

Patch Set 1 : Original land, crashy on leak tests #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M Source/modules/background_sync/PeriodicSyncRegistration.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/background_sync/SyncRegistration.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jkarlin
jsbell: PTAL, thanks!
5 years, 4 months ago (2015-08-17 14:51:39 UTC) #3
jsbell
lgtm, sorry for not checking they were Oilpan objects before.
5 years, 4 months ago (2015-08-17 16:34:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290073003/40001
5 years, 4 months ago (2015-08-17 16:34:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200657
5 years, 4 months ago (2015-08-17 18:41:03 UTC) #9
leviw_travelin_and_unemployed
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/1288893004/ by leviw@chromium.org. ...
5 years, 4 months ago (2015-08-17 20:10:37 UTC) #10
leviw_travelin_and_unemployed
On 2015/08/17 at 20:10:37, leviw wrote: > A revert of this CL (patchset #2 id:40001) ...
5 years, 4 months ago (2015-08-17 21:02:26 UTC) #11
jkarlin
5 years, 4 months ago (2015-08-18 14:53:15 UTC) #12
Message was sent while issue was closed.
Fix for crash: https://codereview.chromium.org/1302543002/
Reland: https://codereview.chromium.org/1299903002/

Powered by Google App Engine
This is Rietveld 408576698