Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2061)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359653002: Clean up WebSyncProvider now that the browser has implemented the necessary functionality. (Closed)

Created:
5 years, 3 months ago by jkarlin
Modified:
5 years, 3 months ago
Reviewers:
jsbell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up WebSyncProvider now that the browser has implemented the necessary functionality. BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202594

Patch Set 1 #

Patch Set 2 : trackRegistration is unused, remove #

Total comments: 4

Patch Set 3 : abstract #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M public/platform/modules/background_sync/WebSyncProvider.h View 1 2 1 chunk +2 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jkarlin
jsbell: PTAL. I'm an owner of the file. Thanks!
5 years, 3 months ago (2015-09-21 14:47:41 UTC) #2
jsbell
Linker issue w/ gn?
5 years, 3 months ago (2015-09-21 17:24:02 UTC) #3
jsbell
https://codereview.chromium.org/1359653002/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h File public/platform/modules/background_sync/WebSyncProvider.h (right): https://codereview.chromium.org/1359653002/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h#newcode51 public/platform/modules/background_sync/WebSyncProvider.h:51: virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks*); Uh, don't you want ...
5 years, 3 months ago (2015-09-21 17:28:28 UTC) #4
jkarlin
https://codereview.chromium.org/1359653002/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h File public/platform/modules/background_sync/WebSyncProvider.h (right): https://codereview.chromium.org/1359653002/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h#newcode51 public/platform/modules/background_sync/WebSyncProvider.h:51: virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks*); On 2015/09/21 17:28:28, jsbell ...
5 years, 3 months ago (2015-09-21 17:32:38 UTC) #5
jsbell
lgtm
5 years, 3 months ago (2015-09-21 18:04:59 UTC) #6
jsbell
lgtm lgtm
5 years, 3 months ago (2015-09-21 18:05:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359653002/40001
5 years, 3 months ago (2015-09-21 18:11:49 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:55:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202594

Powered by Google App Engine
This is Rietveld 408576698