Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1279303002: Expand functionality of GrRectBatchFactory with AARects (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@batchfactory3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Expand functionality of GrRectBatchFactory with AARects BUG=skia: Committed: https://skia.googlesource.com/skia/+/14205b114a7d834d0627b8c9acb234f4d809388d

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -241 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D src/gpu/GrAARectRenderer.h View 1 1 chunk +0 lines, -73 lines 0 comments Download
D src/gpu/GrAARectRenderer.cpp View 1 1 chunk +0 lines, -143 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 3 chunks +9 lines, -17 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 2 chunks +18 lines, -2 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 3 chunks +109 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1282283002 Patch 20001

Dependent Patchsets:

Issue 1282883002 Patch 1
Issue 1282883002 Patch 20001

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-10 18:01:15 UTC) #2
bsalomon
On 2015/08/10 18:01:15, joshualitt wrote: > ptal lgtm
5 years, 4 months ago (2015-08-10 18:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279303002/20001
5 years, 4 months ago (2015-08-10 18:33:32 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 18:41:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/14205b114a7d834d0627b8c9acb234f4d809388d

Powered by Google App Engine
This is Rietveld 408576698