Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282283002: Move GrStrokeRectBatch creation to behind factory (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@batchfactory2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrStrokeRectBatch creation to behind factory BUG=skia: Committed: https://skia.googlesource.com/skia/+/7fc2a2610ec31a659fe2603f8960d376822d54cb

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M src/gpu/GrDrawContext.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 1 chunk +11 lines, -5 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 1 2 chunks +19 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1287433003 Patch 1

Dependent Patchsets:

Issue 1279303002 Patch 1
Issue 1279303002 Patch 20001

Messages

Total messages: 7 (3 generated)
joshualitt
A simple patch to move GrStrokeRectBatch create into GrBatchFactory
5 years, 4 months ago (2015-08-10 16:25:11 UTC) #2
robertphillips
lgtm + nit https://codereview.chromium.org/1282283002/diff/1/src/gpu/batches/GrRectBatchFactory.cpp File src/gpu/batches/GrRectBatchFactory.cpp (right): https://codereview.chromium.org/1282283002/diff/1/src/gpu/batches/GrRectBatchFactory.cpp#newcode15 src/gpu/batches/GrRectBatchFactory.cpp:15: GrBatch* CreateFillBW(GrColor color, tab these over ...
5 years, 4 months ago (2015-08-10 16:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282283002/20001
5 years, 4 months ago (2015-08-10 17:22:48 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 17:30:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7fc2a2610ec31a659fe2603f8960d376822d54cb

Powered by Google App Engine
This is Rietveld 408576698