Issue 1279043002: [heap] Rename IncrementalMarking::Abort to Stop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1279043002: [heap] Rename IncrementalMarking::Abort to Stop. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[heap] Rename IncrementalMarking::Abort to Stop. R=hpayer@chromium.org Committed: https://crrev.com/fc77fb7bddcac5132d6c3941288a9819a9d5501a Cr-Commit-Position: refs/heads/master@{#30061}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	src/heap/incremental-marking.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/heap/incremental-marking.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap/mark-compact.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Dependent Patchsets:

Issue 1273953004 Patch 1

Issue 1273953004 Patch 20001

Issue 1273953004 Patch 40001

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hannes Payer (out of office)

LGTM. There is more clean-up work left...

5 years, 4 months ago (2015-08-07 08:55:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279043002/1

5 years, 4 months ago (2015-08-07 09:07:36 UTC) #3

commit-bot: I haz the power

5 years, 4 months ago (2015-08-07 09:37:09 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fc77fb7bddcac5132d6c3941288a9819a9d5501a
Cr-Commit-Position: refs/heads/master@{#30061}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages