[heap] Remove obsolete was_marked_incrementally field.

[heap] Remove obsolete was_marked_incrementally field.

R=hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-07 09:57:31]

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:2245: incremental_marking->Stop();
stop is now not called for non-aborting GCs. We should take care of that in
prepare.

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:2239: IncrementalMarking* incremental_marking =
heap_->incremental_marking();
It would be nicer to move the chunk of code that deals with incremental marking
to the prepare function.

[Michael Starzinger, 2015-08-07 10:01:54]

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:2245: incremental_marking->Stop();
On 2015/08/07 09:57:31, Hannes Payer wrote:
> stop is now not called for non-aborting GCs. We should take care of that in
> prepare.

Done. Yep, my think-o, the try-jobs caught that.

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:2239: IncrementalMarking* incremental_marking =
heap_->incremental_marking();
On 2015/08/07 09:57:31, Hannes Payer wrote:
> It would be nicer to move the chunk of code that deals with incremental
marking
> to the prepare function.

Acknowledged. Would you be fine with doing that in a separate CL or should I do
it in this one?

[Hannes Payer (out of office), 2015-08-07 10:39:23]

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:2239: IncrementalMarking* incremental_marking =
heap_->incremental_marking();
On 2015/08/07 10:01:54, Michael Starzinger wrote:
> On 2015/08/07 09:57:31, Hannes Payer wrote:
> > It would be nicer to move the chunk of code that deals with incremental
> marking
> > to the prepare function.
> 
> Acknowledged. Would you be fine with doing that in a separate CL or should I
do
> it in this one?

let's just do it in this one.

[Hannes Payer (out of office), 2015-08-07 10:53:38]

https://codereview.chromium.org/1273953004/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1273953004/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:816: heap()->incremental_marking()->Stop();
in that case, stop was already performed before.

https://codereview.chromium.org/1273953004/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:818: marking_deque_.Uninitialize(true);
Why are we doing this just in this case?

[Michael Starzinger, 2015-12-14 21:15:01]

Closing. Approach doesn't fly. :(

[Michael Starzinger, 2015-12-14 21:15:11]

Description was changed from

==========
[heap] Remove obsolete was_marked_incrementally field.

R=hpayer@chromium.org
==========

to

==========
[heap] Remove obsolete was_marked_incrementally field.

R=hpayer@chromium.org
==========