Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1278783002: [es6] Use strict arguments objects for destructured parameters (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Use strict arguments objects for destructured parameters Plus some renaming for consistency. R=adamk@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/826f8da55fb868a365d047a4a653eb8ff2bfc14e Cr-Commit-Position: refs/heads/master@{#30064}

Patch Set 1 #

Patch Set 2 : Missing platforms #

Patch Set 3 : Doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -38 lines) Patch
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scopeinfo.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/scopes.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/scopes.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
rossberg
5 years, 4 months ago (2015-08-06 16:16:14 UTC) #1
adamk
Can you add some tests with arrow functions? Want to make sure that's covered, as ...
5 years, 4 months ago (2015-08-06 17:12:43 UTC) #2
adamk
lgtm with added tests, though
5 years, 4 months ago (2015-08-06 18:41:33 UTC) #3
rossberg
On 2015/08/06 17:12:43, adamk wrote: > Can you add some tests with arrow functions? Want ...
5 years, 4 months ago (2015-08-06 18:56:29 UTC) #4
adamk
On 2015/08/06 18:56:29, rossberg wrote: > On 2015/08/06 17:12:43, adamk wrote: > > Can you ...
5 years, 4 months ago (2015-08-06 18:59:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278783002/20001
5 years, 4 months ago (2015-08-06 20:26:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8364)
5 years, 4 months ago (2015-08-06 20:40:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278783002/40001
5 years, 4 months ago (2015-08-07 11:13:28 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-07 11:38:29 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 11:38:58 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/826f8da55fb868a365d047a4a653eb8ff2bfc14e
Cr-Commit-Position: refs/heads/master@{#30064}

Powered by Google App Engine
This is Rietveld 408576698