src/full-codegen/x64/full-codegen-x64.cc - Issue 1278783002: [es6] Use strict arguments objects for destructured parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1278783002: [es6] Use strict arguments objects for destructured parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Doh Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 65c0456dc70c32da4a18bfa18f326be43ec30a2c..206048f36986b8472d0a1037a449ddf26d70ff0a 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -319,7 +319,7 @@ void FullCodeGenerator::Generate() {

// stack frame was an arguments adapter frame.

ArgumentsAccessStub::Type type;

- if (is_strict(language_mode()) || !is_simple_parameter_list()) {

+ if (is_strict(language_mode()) || !has_simple_parameters()) {

type = ArgumentsAccessStub::NEW_STRICT;

} else if (function()->has_duplicate_parameters()) {

type = ArgumentsAccessStub::NEW_SLOPPY_SLOW;

« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »