Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: src/objects-inl.h

Issue 1278783002: [es6] Use strict arguments objects for destructured parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Doh Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5360 matching lines...) Expand 10 before | Expand all | Expand 10 after
5371 5371
5372 5372
5373 bool SharedFunctionInfo::is_compiled() { 5373 bool SharedFunctionInfo::is_compiled() {
5374 Builtins* builtins = GetIsolate()->builtins(); 5374 Builtins* builtins = GetIsolate()->builtins();
5375 DCHECK(code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent)); 5375 DCHECK(code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent));
5376 DCHECK(code() != builtins->builtin(Builtins::kCompileOptimized)); 5376 DCHECK(code() != builtins->builtin(Builtins::kCompileOptimized));
5377 return code() != builtins->builtin(Builtins::kCompileLazy); 5377 return code() != builtins->builtin(Builtins::kCompileLazy);
5378 } 5378 }
5379 5379
5380 5380
5381 bool SharedFunctionInfo::is_simple_parameter_list() { 5381 bool SharedFunctionInfo::has_simple_parameters() {
5382 return scope_info()->IsSimpleParameterList(); 5382 return scope_info()->HasSimpleParameters();
5383 } 5383 }
5384 5384
5385 5385
5386 bool SharedFunctionInfo::HasDebugInfo() { 5386 bool SharedFunctionInfo::HasDebugInfo() {
5387 bool has_debug_info = debug_info()->IsStruct(); 5387 bool has_debug_info = debug_info()->IsStruct();
5388 DCHECK(!has_debug_info || HasDebugCode()); 5388 DCHECK(!has_debug_info || HasDebugCode());
5389 return has_debug_info; 5389 return has_debug_info;
5390 } 5390 }
5391 5391
5392 5392
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
5678 5678
5679 5679
5680 bool JSFunction::is_compiled() { 5680 bool JSFunction::is_compiled() {
5681 Builtins* builtins = GetIsolate()->builtins(); 5681 Builtins* builtins = GetIsolate()->builtins();
5682 return code() != builtins->builtin(Builtins::kCompileLazy) && 5682 return code() != builtins->builtin(Builtins::kCompileLazy) &&
5683 code() != builtins->builtin(Builtins::kCompileOptimized) && 5683 code() != builtins->builtin(Builtins::kCompileOptimized) &&
5684 code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent); 5684 code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent);
5685 } 5685 }
5686 5686
5687 5687
5688 bool JSFunction::is_simple_parameter_list() { 5688 bool JSFunction::has_simple_parameters() {
5689 return shared()->is_simple_parameter_list(); 5689 return shared()->has_simple_parameters();
5690 } 5690 }
5691 5691
5692 5692
5693 FixedArray* JSFunction::literals() { 5693 FixedArray* JSFunction::literals() {
5694 DCHECK(!shared()->bound()); 5694 DCHECK(!shared()->bound());
5695 return literals_or_bindings(); 5695 return literals_or_bindings();
5696 } 5696 }
5697 5697
5698 5698
5699 void JSFunction::set_literals(FixedArray* literals) { 5699 void JSFunction::set_literals(FixedArray* literals) {
(...skipping 1521 matching lines...) Expand 10 before | Expand all | Expand 10 after
7221 #undef READ_INT64_FIELD 7221 #undef READ_INT64_FIELD
7222 #undef WRITE_INT64_FIELD 7222 #undef WRITE_INT64_FIELD
7223 #undef READ_BYTE_FIELD 7223 #undef READ_BYTE_FIELD
7224 #undef WRITE_BYTE_FIELD 7224 #undef WRITE_BYTE_FIELD
7225 #undef NOBARRIER_READ_BYTE_FIELD 7225 #undef NOBARRIER_READ_BYTE_FIELD
7226 #undef NOBARRIER_WRITE_BYTE_FIELD 7226 #undef NOBARRIER_WRITE_BYTE_FIELD
7227 7227
7228 } } // namespace v8::internal 7228 } } // namespace v8::internal
7229 7229
7230 #endif // V8_OBJECTS_INL_H_ 7230 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698