Split GenerateBenchGraphs into three build steps

Split GenerateBenchGraphs into three build steps

- Regression testing
- Graph generation
- Upload data to AppEngine

Depends on https://codereview.chromium.org/12543019/
Committed: https://code.google.com/p/skia/source/detail?r=8122

[borenet, 2013-03-12 12:15:37]

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
File slave/skia_slave_scripts/check_for_regressions.py (right):

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
slave/skia_slave_scripts/check_for_regressions.py:1: #!/usr/bin/env python
SVN-copied from generate_bench_graphs.py.

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
File slave/skia_slave_scripts/upload_bench_results_appengine.py (right):

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
slave/skia_slave_scripts/upload_bench_results_appengine.py:1: #!/usr/bin/env
python
SVN-copied from generate_bench_graphs.py.

[borenet, 2013-03-12 13:03:20]

On 2013/03/12 12:15:37, borenet wrote:
>
https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
> File slave/skia_slave_scripts/check_for_regressions.py (right):
> 
>
https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
> slave/skia_slave_scripts/check_for_regressions.py:1: #!/usr/bin/env python
> SVN-copied from generate_bench_graphs.py.
> 
>
https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
> File slave/skia_slave_scripts/upload_bench_results_appengine.py (right):
> 
>
https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
> slave/skia_slave_scripts/upload_bench_results_appengine.py:1: #!/usr/bin/env
> python
> SVN-copied from generate_bench_graphs.py.

See this try run of https://codereview.chromium.org/12543019/ on my local
master, which is running with this change:
http://nautilus.cnc.corp.google.com:10125/builders/Skia_Shuttle_Ubuntu12_ATI5...

[epoger, 2013-03-12 15:58:33]

LGTM

https://codereview.chromium.org/12785002/diff/1/master/skia_master_scripts/fa...
File master/skia_master_scripts/factory.py (right):

https://codereview.chromium.org/12785002/diff/1/master/skia_master_scripts/fa...
master/skia_master_scripts/factory.py:338: def CheckForRegressions(self):
maybe CheckForBenchRegressions ?  Just to differentiate from gm regressions,
etc.

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
File slave/skia_slave_scripts/check_for_regressions.py (right):

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/chec...
slave/skia_slave_scripts/check_for_regressions.py:27: cmd = ['python',
path_to_bench_graph_svg,
Maybe add a comment like this?

Run bench_graph_svg in such a mode that it just looks for performance
regressions in the most recent revision.

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
File slave/skia_slave_scripts/upload_bench_results_appengine.py (right):

https://codereview.chromium.org/12785002/diff/1/slave/skia_slave_scripts/uplo...
slave/skia_slave_scripts/upload_bench_results_appengine.py:27: cmd = ['python',
path_to_bench_graph_svg,
Maybe add comment like this:

Run bench_graph_svg in such a mode that it just uploads the latest benchmark
data to AppEngine.

[benchen, 2013-03-12 17:07:11]

Sorry if I misunderstood it - splitting it into 3 steps means the raw logs will
be parsed 3 times (at least the most recent one), but since two of the steps
require only parsing of the latest revisions, running time won't be a big issue.
If so, LGTM on this CL, and looking forward to seeing all the steps turned on.

[borenet, 2013-03-13 11:40:25]

Committed patchset #1 manually as r8122 (presubmit successful).