Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: master/skia_master_scripts/factory.py

Issue 12785002: Split GenerateBenchGraphs into three build steps (Closed) Base URL: http://skia.googlecode.com/svn/buildbot/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | site_config/global_variables.json » ('j') | slave/skia_slave_scripts/check_for_regressions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/factory.py
===================================================================
--- master/skia_master_scripts/factory.py (revision 8090)
+++ master/skia_master_scripts/factory.py (working copy)
@@ -335,6 +335,11 @@
self.AddFlavoredSlaveScript(script='bench_pictures.py',
description='BenchPictures')
+ def CheckForRegressions(self):
epoger 2013/03/12 15:58:33 maybe CheckForBenchRegressions ? Just to differen
+ """ Check for benchmark regressions. """
+ self.AddSlaveScript(script='check_for_regressions.py',
+ description='CheckForRegressions')
+
def BenchGraphs(self):
""" Generate bench performance graphs. """
self.AddSlaveScript(script='generate_bench_graphs.py',
@@ -399,6 +404,11 @@
self.AddSlaveScript(script='upload_bench_results.py',
description='UploadBenchResults')
+ def UploadBenchResultsToAppEngine(self):
+ """ Upload bench results (performance data) to AppEngine. """
+ self.AddSlaveScript(script='upload_bench_results_appengine.py',
+ description='UploadBenchResultsToAppengine')
+
def UploadWebpagePictureBenchResults(self):
""" Upload webpage picture bench results (performance data). """
self.AddSlaveScript(script='upload_webpage_picture_bench_results.py',
@@ -441,9 +451,11 @@
self.RunBench()
self.BenchPictures()
self.PostBench()
+ self.CheckForRegressions()
self.BenchGraphs()
if self._do_upload_bench_results:
self.UploadBenchResults()
+ self.UploadBenchResultsToAppEngine()
self.UploadBenchGraphs()
def Build(self, clobber=None):
« no previous file with comments | « no previous file | site_config/global_variables.json » ('j') | slave/skia_slave_scripts/check_for_regressions.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698