Split GenerateBenchGraphs into three build steps

master/skia_master_scripts/factory.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Utility class to build the Skia master BuildFactory's.
 
 Based on gclient_factory.py and adds Skia-specific steps."""
 
 
@@ skipping 317 matching lines @@
   def RunBench(self):
     """ Run "bench", piping the output somewhere so we can graph
     results over time. """
     self.AddFlavoredSlaveScript(script='run_bench.py', description='RunBench')
 
   def BenchPictures(self):
     """ Run "bench_pictures" """
     self.AddFlavoredSlaveScript(script='bench_pictures.py',
                                 description='BenchPictures')
 
+  def CheckForRegressions(self):

[epoger, 2013/03/12 15:58:33]

maybe CheckForBenchRegressions ?  Just to differentiate from gm regressions,
etc.

+    """ Check for benchmark regressions. """
+    self.AddSlaveScript(script='check_for_regressions.py',
+                        description='CheckForRegressions')
+
   def BenchGraphs(self):
     """ Generate bench performance graphs. """
     self.AddSlaveScript(script='generate_bench_graphs.py',
                         description='GenerateBenchGraphs')
 
   def GenerateWebpagePictureBenchGraphs(self):
     """ Generate webpage picture bench performance graphs. """
     self.AddSlaveScript(script='generate_webpage_picture_bench_graphs.py',
                         description='GenerateWebpagePictureBenchGraphs')
 
@@ skipping 44 matching lines @@
     """ Upload webpage picture bench performance graphs (but only if we have
     been recording bench output for this build type). """
     self.AddSlaveScript(script='upload_webpage_picture_bench_graphs.py',
                         description='UploadWebpagePictureBenchGraphs')
 
   def UploadBenchResults(self):
     """ Upload bench results (performance data). """
     self.AddSlaveScript(script='upload_bench_results.py',
                         description='UploadBenchResults')
 
+  def UploadBenchResultsToAppEngine(self):
+    """ Upload bench results (performance data) to AppEngine. """
+    self.AddSlaveScript(script='upload_bench_results_appengine.py',
+                        description='UploadBenchResultsToAppengine')
+
   def UploadWebpagePictureBenchResults(self):
     """ Upload webpage picture bench results (performance data). """
     self.AddSlaveScript(script='upload_webpage_picture_bench_results.py',
                         description='UploadWebpagePictureBenchResults')
 
 
   def UploadGMResults(self):
     """ Upload the images generated by GM """
     args = ['--autogen_svn_username_file', self._autogen_svn_username_file,
             '--autogen_svn_password_file', self._autogen_svn_password_file]
@@ skipping 22 matching lines @@
       if self._use_skp_playback_framework:
         self.CompareAndUploadWebpageGMs()
     self.CompareGMs()
 
   def PerfSteps(self):
     """ Add performance testing BuildSteps. """
     self.PreBench()
     self.RunBench()
     self.BenchPictures()
     self.PostBench()
+    self.CheckForRegressions()
     self.BenchGraphs()
     if self._do_upload_bench_results:
       self.UploadBenchResults()
+      self.UploadBenchResultsToAppEngine()
       self.UploadBenchGraphs()
 
   def Build(self, clobber=None):
     """Build and return the complete BuildFactory.
 
     clobber: boolean indicating whether we should clean before building
     """
     self.CommonSteps(clobber)
     self.NonPerfSteps()
     self.PerfSteps()
@@ skipping 17 matching lines @@
     """
     if not self._perf_output_basedir:
       raise ValueError(
           'BuildPerfOnly requires perf_output_basedir to be defined.')
     if self._configuration != CONFIG_RELEASE:
       raise ValueError('BuildPerfOnly should run in %s configuration.' %
                        CONFIG_RELEASE)
     self.CommonSteps(clobber)
     self.PerfSteps()
     return self