Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1278173004: Revert of Update libwebp and resume testing scaled webp (Closed)

Created:
5 years, 4 months ago by scroggo
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update libwebp and resume testing scaled webp (patchset #2 id:20001 of https://codereview.chromium.org/1280073002/ ) Reason for revert: Compile failures, e.g. http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon/builds/1427/steps/build%20most/logs/stdio Original issue's description: > Update libwebp and resume testing scaled webp > > libwebp has a fix for [1]. Update to the commit that contains the fix. > > Update libwebp.gypi, corresponding to libwebp's latest makefile. > > Turn back on DM testing for scaled webp, now that it should no longer > use uninitialized memory. > > Fix a warning in config.h > > [1] https://code.google.com/p/webp/issues/detail?id=254 > > BUG=skia:4038 > > Committed: https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339 TBR=djsollen@google.com,msarett@google.com,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4038 Committed: https://skia.googlesource.com/skia/+/0df0e43488dc785815d3234d9bd60bad91532f98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -56 lines) Patch
M DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M dm/DM.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/libwebp.gyp View 4 chunks +0 lines, -51 lines 0 comments Download
M third_party/libwebp/webp/config.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Update libwebp and resume testing scaled webp
5 years, 4 months ago (2015-08-07 19:53:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278173004/1
5 years, 4 months ago (2015-08-07 19:53:19 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:53:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0df0e43488dc785815d3234d9bd60bad91532f98

Powered by Google App Engine
This is Rietveld 408576698