dm/DM.cpp - Issue 1278173004: Revert of Update libwebp and resume testing scaled webp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 1278173004: Revert of Update libwebp and resume testing scaled webp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index 0faa3e4a50f73d0a507f10acddb1113b8206063e..9dcdff1a0fce6f98f10228d33595e618a31f4c2e 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -215,6 +215,11 @@

const float scales[] = { 0.125f, 0.25f, 0.375f, 0.5f, 0.625f, 0.750f, 0.875f, 1.0f };

for (float scale : scales) {

+ if (scale != 1.0f && (path.endsWith(".webp") || path.endsWith(".WEBP"))) {

+ // FIXME: skbug.com/4038 Scaling webp seems to leave some pixels uninitialized/

+ // compute their colors based on uninitialized values.

+ continue;

+ }

// Build additional test cases for images that decode natively to non-canvas types

switch(codec->getInfo().colorType()) {

case kGray_8_SkColorType:

« no previous file with comments | « DEPS ('k') | gyp/libwebp.gyp » ('j') | no next file with comments »