chrome/browser/resources/extensions/extension_error.js - Issue 1277833003: Re-use local variable instead of querySelector()ing it again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_error.js

Issue 1277833003: Re-use local variable instead of querySelector()ing it again (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_error.js

diff --git a/chrome/browser/resources/extensions/extension_error.js b/chrome/browser/resources/extensions/extension_error.js

index c9296554d9aea901150212419fc8e1befca30780..fbf4d77b4c2a3fc70583f9ea6ec52f2af7fcaec6 100644

--- a/chrome/browser/resources/extensions/extension_error.js

+++ b/chrome/browser/resources/extensions/extension_error.js

@@ -131,7 +131,7 @@ cr.define('extensions', function() {

});

this.addFocusableElement(this);

- this.addFocusableElement(this.querySelector('.error-delete-button'));

+ this.addFocusableElement(deleteButton);

hcarmona 2015/08/11 01:39:35 I'm curious how this behaves because |this| and |d

Dan Beam 2015/08/11 01:41:55 Acknowledged.

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »