chrome/test/chromedriver/basic_types.h - Issue 12764021: [chromedriver] Support clicking an element in sub frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/basic_types.h

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/basic_types.h

diff --git a/chrome/test/chromedriver/basic_types.h b/chrome/test/chromedriver/basic_types.h

index 8a623c481d3b944f3001b1a620defe9712170ee0..6b28e5fd890ec944b2213493d0b2369526bcfbcd 100644

--- a/chrome/test/chromedriver/basic_types.h

+++ b/chrome/test/chromedriver/basic_types.h

@@ -10,7 +10,9 @@ struct WebPoint {

WebPoint(int x, int y);

~WebPoint();

- void offset(int x_, int y_);

+ void Offset(int x_, int y_);

+ int X() const;

kkania 2013/03/13 00:06:20 why do we need these?

chrisgao (Use stgao instead) 2013/03/13 00:36:48 Whoops, i thought direct access to const object me

+ int Y() const;

int x;

int y;

@@ -21,6 +23,9 @@ struct WebSize {

WebSize(int width, int height);

~WebSize();

+ int Width() const;

kkania 2013/03/13 00:06:20 why?

chrisgao (Use stgao instead) 2013/03/13 00:36:48 Removed.

+ int Height() const;

int width;

int height;

};

@@ -31,10 +36,10 @@ struct WebRect {

WebRect(const WebPoint& origin, const WebSize& size);

~WebRect();

- int x();

- int y();

- int width();

- int height();

+ int X() const;

+ int Y() const;

+ int Width() const;

+ int Height() const;

WebPoint origin;

WebSize size;

« no previous file with comments | « no previous file | chrome/test/chromedriver/basic_types.cc » ('j') | chrome/test/chromedriver/run_py_tests.py » ('J')