Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/test/chromedriver/basic_types.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/basic_types.cc
diff --git a/chrome/test/chromedriver/basic_types.cc b/chrome/test/chromedriver/basic_types.cc
index ef6b2f39a6a8972938560915057cc5bce3d43902..9334914271a1ba85ae9e4e5aa7653e72fb66994e 100644
--- a/chrome/test/chromedriver/basic_types.cc
+++ b/chrome/test/chromedriver/basic_types.cc
@@ -10,17 +10,25 @@ WebPoint::WebPoint(int x, int y) : x(x), y(y) {}
WebPoint::~WebPoint() {}
-void WebPoint::offset(int x_, int y_) {
+void WebPoint::Offset(int x_, int y_) {
x += x_;
y += y_;
}
+int WebPoint::X() const { return x; }
+
+int WebPoint::Y() const { return y; }
+
WebSize::WebSize() : width(0), height(0) {}
WebSize::WebSize(int width, int height) : width(width), height(height) {}
WebSize::~WebSize() {}
+int WebSize::Width() const { return width; }
+
+int WebSize::Height() const { return height; }
+
WebRect::WebRect() : origin(0, 0), size(0, 0) {}
WebRect::WebRect(int x, int y, int width, int height)
@@ -31,10 +39,10 @@ WebRect::WebRect(const WebPoint& origin, const WebSize& size)
WebRect::~WebRect() {}
-int WebRect::x() { return origin.x; }
+int WebRect::X() const { return origin.X(); }
-int WebRect::y() { return origin.y; }
+int WebRect::Y() const { return origin.Y(); }
-int WebRect::width() { return size.width; }
+int WebRect::Width() const { return size.Width(); }
-int WebRect::height() { return size.height; }
+int WebRect::Height() const { return size.Height(); }

Powered by Google App Engine
This is Rietveld 408576698