chrome/test/chromedriver/basic_types.h - Issue 12764021: [chromedriver] Support clicking an element in sub frames.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/basic_types.h

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_	5 #ifndef CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_

6 #define CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_	6 #define CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_

7	7

8 struct WebPoint {	8 struct WebPoint {

9 WebPoint();	9 WebPoint();

10 WebPoint(int x, int y);	10 WebPoint(int x, int y);

11 ~WebPoint();	11 ~WebPoint();

12	12

13 void offset(int x_, int y_);	13 void Offset(int x_, int y_);

	14 int X() const;
	kkania 2013/03/13 00:06:20 why do we need these? why do we need these? chrisgao (Use stgao instead) 2013/03/13 00:36:48 Whoops, i thought direct access to const object me Show quoted text On 2013/03/13 00:06:20, kkania wrote: > why do we need these? Whoops, i thought direct access to const object member leads to compile error.
	15 int Y() const;

14	16

15 int x;	17 int x;

16 int y;	18 int y;

17 };	19 };

18	20

19 struct WebSize {	21 struct WebSize {

20 WebSize();	22 WebSize();

21 WebSize(int width, int height);	23 WebSize(int width, int height);

22 ~WebSize();	24 ~WebSize();

23	25

	26 int Width() const;
	kkania 2013/03/13 00:06:20 why? why? chrisgao (Use stgao instead) 2013/03/13 00:36:48 Removed. Show quoted text On 2013/03/13 00:06:20, kkania wrote: > why? Removed.
	27 int Height() const;

	28

24 int width;	29 int width;

25 int height;	30 int height;

26 };	31 };

27	32

28 struct WebRect {	33 struct WebRect {

29 WebRect();	34 WebRect();

30 WebRect(int x, int y, int width, int height);	35 WebRect(int x, int y, int width, int height);

31 WebRect(const WebPoint& origin, const WebSize& size);	36 WebRect(const WebPoint& origin, const WebSize& size);

32 ~WebRect();	37 ~WebRect();

33	38

34 int x();	39 int X() const;

35 int y();	40 int Y() const;

36 int width();	41 int Width() const;

37 int height();	42 int Height() const;

38	43

39 WebPoint origin;	44 WebPoint origin;

40 WebSize size;	45 WebSize size;

41 };	46 };

42	47

43 #endif // CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_	48 #endif // CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/chromedriver/basic_types.cc » ('j') | chrome/test/chromedriver/run_py_tests.py » ('J')