Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1276353003: [api] Delete non-maybe version of CompileModule (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Delete non-maybe version of CompileModule Also add a bigger warning to the header comment for the Maybe version. R=jochen@chromium.org Committed: https://crrev.com/d746dbfed7b8493d9ff46fc5ef824ea171993782 Cr-Commit-Position: refs/heads/master@{#30137}

Patch Set 1 #

Patch Set 2 : Remove implementation of deprecated method and unused call from tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M include/v8.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/api.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 4 months ago (2015-08-07 18:56:59 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-12 16:14:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276353003/20001
5 years, 4 months ago (2015-08-12 16:17:43 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 16:43:12 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 16:43:27 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d746dbfed7b8493d9ff46fc5ef824ea171993782
Cr-Commit-Position: refs/heads/master@{#30137}

Powered by Google App Engine
This is Rietveld 408576698