Issue 1276353003: [api] Delete non-maybe version of CompileModule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276353003: [api] Delete non-maybe version of CompileModule (Closed)

Created:
5 years, 4 months ago by adamk

Modified:
5 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[api] Delete non-maybe version of CompileModule Also add a bigger warning to the header comment for the Maybe version. R=jochen@chromium.org Committed: https://crrev.com/d746dbfed7b8493d9ff46fc5ef824ea171993782 Cr-Commit-Position: refs/heads/master@{#30137}

Patch Set 1 #

Patch Set 2 : Remove implementation of deprecated method and unused call from tests #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -20 lines)			Patch
M	include/v8.h	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	test/cctest/cctest.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276353003/20001

5 years, 4 months ago (2015-08-12 16:17:43 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-12 16:43:27 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/d746dbfed7b8493d9ff46fc5ef824ea171993782
Cr-Commit-Position: refs/heads/master@{#30137}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages