Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2349)

Unified Diff: src/api.cc

Issue 1276353003: [api] Delete non-maybe version of CompileModule (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove implementation of deprecated method and unused call from tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | test/cctest/cctest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 8615d8245d68b3386470c2c00b0dfe9890336529..8e2604727529174d6ed421746bfa3d343f3317c7 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -1806,13 +1806,6 @@ MaybeLocal<Script> ScriptCompiler::CompileModule(Local<Context> context,
}
-Local<Script> ScriptCompiler::CompileModule(Isolate* v8_isolate, Source* source,
- CompileOptions options) {
- auto context = v8_isolate->GetCurrentContext();
- RETURN_TO_LOCAL_UNCHECKED(CompileModule(context, source, options), Script);
-}
-
-
class IsIdentifierHelper {
public:
IsIdentifierHelper() : is_identifier_(false), first_char_(true) {}
« no previous file with comments | « include/v8.h ('k') | test/cctest/cctest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698