Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: include/v8.h

Issue 1276353003: [api] Delete non-maybe version of CompileModule (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove implementation of deprecated method and unused call from tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 19373a1398720ad1816df0dfd49ec5f8f88a86c0..38a9e7c6662c2df125eb38fcf0fa109de966c38d 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1385,15 +1385,13 @@ class V8_EXPORT ScriptCompiler {
/**
* Compile an ES6 module.
*
- * This is an experimental feature.
+ * This is an unfinished experimental feature, and is only exposed
+ * here for internal testing purposes.
+ * Only parsing works at the moment. Do not use.
*
* TODO(adamk): Script is likely the wrong return value for this;
* should return some new Module type.
*/
- static V8_DEPRECATE_SOON(
- "Use maybe version",
- Local<Script> CompileModule(Isolate* isolate, Source* source,
- CompileOptions options = kNoCompileOptions));
static V8_WARN_UNUSED_RESULT MaybeLocal<Script> CompileModule(
Local<Context> context, Source* source,
CompileOptions options = kNoCompileOptions);
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698