Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1276113002: Security: disable nontemporals. (Closed)

Created:
5 years, 4 months ago by JF
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Security: disable nontemporals. The operations were available on ARM64 and x86-32 but were unused. It has been conjectured that nontemporals can be used for rowhammer-like bitflips more easily than regular load/store operations. It is therefore desirable to avoid generating these instructions in the future. R= titzer, jochen, jln, Mark Seaborn, ruiq Committed: https://crrev.com/a904b569a21ae18f34dd4034b58b283f425a34c6 Cr-Commit-Position: refs/heads/master@{#30139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -250 lines) Patch
M src/arm64/assembler-arm64.h View 3 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/arm64/constants-arm64.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/decoder-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/decoder-arm64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/disasm-arm64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/arm64/instrument-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/x87/disasm-x87.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
JF
PTAL.
5 years, 4 months ago (2015-08-06 23:05:45 UTC) #2
Mark Seaborn
It's not my codebase, but removing the possibility of using these instructions looks like a ...
5 years, 4 months ago (2015-08-10 16:12:44 UTC) #3
titzer
On 2015/08/10 16:12:44, Mark Seaborn wrote: > It's not my codebase, but removing the possibility ...
5 years, 4 months ago (2015-08-12 09:44:05 UTC) #4
JF
On 2015/08/12 09:44:05, titzer wrote: > On 2015/08/10 16:12:44, Mark Seaborn wrote: > > It's ...
5 years, 4 months ago (2015-08-12 15:59:08 UTC) #5
titzer
On 2015/08/12 15:59:08, JF wrote: > On 2015/08/12 09:44:05, titzer wrote: > > On 2015/08/10 ...
5 years, 4 months ago (2015-08-12 16:07:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276113002/1
5 years, 4 months ago (2015-08-12 16:34:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 16:57:58 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 16:58:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a904b569a21ae18f34dd4034b58b283f425a34c6
Cr-Commit-Position: refs/heads/master@{#30139}

Powered by Google App Engine
This is Rietveld 408576698