Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 1275743003: Deliver action clicks to page notifications (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_test
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_notification_manager.cc
diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.cc b/content/shell/browser/layout_test/layout_test_notification_manager.cc
index 6505a9d9b267b1331d43ecd5ba9cde2d887c26ae..ea7cf8fa5741ca51d7b16137b0ea3c74daaca664 100644
--- a/content/shell/browser/layout_test/layout_test_notification_manager.cc
+++ b/content/shell/browser/layout_test/layout_test_notification_manager.cc
@@ -113,10 +113,7 @@ void LayoutTestNotificationManager::SimulateClick(const std::string& title,
// First check for page-notifications with the given title.
const auto& page_iterator = page_notifications_.find(title);
if (page_iterator != page_notifications_.end()) {
- // TODO(johnme): Implement this.
- CHECK(action_index < 0) << "Simulating action clicks for page notifications"
- << " is not yet implemented";
- page_iterator->second->NotificationClick();
+ page_iterator->second->NotificationClick(action_index);
return;
}

Powered by Google App Engine
This is Rietveld 408576698