Fix device_utils.SetProp not properly clearing cached value

build/android/pylib/device/device_utils.py

Index: build/android/pylib/device/device_utils.py
diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py
index 2d9671d01034f64873c5c0ebd2b889f0e896703c..0ea9a264ed900f81307d96d3905b376c867167cf 100644
--- a/build/android/pylib/device/device_utils.py
+++ b/build/android/pylib/device/device_utils.py
@@ -1558,8 +1558,9 @@ class DeviceUtils(object):
     assert isinstance(value, basestring), "value is not a string: %r" % value
 
     self.RunShellCommand(['setprop', property_name, value], check_return=True)
-    if property_name in self._cache:
-      del self._cache[property_name]
+    cache_key = '_prop:' + property_name

[jbudorick, 2015/08/11 00:47:54]

optional nit: wdyt about a _PropertyCacheKey function here and up in GetProp?

[agrieve, 2015/08/11 13:51:56]

If we're going to go with having sub-caches for APK checksums, then it might
make more sense to have this in its own namespace as well:
self._cache['props'][property_name].

Will just leave as-is for now.

[jbudorick, 2015/08/11 13:53:18]

Hmm, good point.
sgtm

+    if cache_key in self._cache:
+      del self._cache[cache_key]
     # TODO(perezju) remove the option and make the check mandatory, but using a
     # single shell script to both set- and getprop.
     if check and value != self.GetProp(property_name):