Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: src/heap/mark-compact.h

Issue 1273953004: [heap] Remove obsolete was_marked_incrementally field. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-incremental-marking-stop
Patch Set: Addressed comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | src/heap/mark-compact.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index d78e9bddee44b0f2a1b396e49a4bd90f60bd20d7..ea0d5e66e7bd45acf20c000a2cf8e7c108725d7b 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -778,11 +778,11 @@ class MarkCompactCollector {
CollectorState state_;
#endif
- bool reduce_memory_footprint_;
-
- bool abort_incremental_marking_;
-
- bool finalize_incremental_marking_;
+ // The following flags are controlled via {SetFlags} by the caller, it has to
+ // be called before {Prepare} to take effect.
+ bool reduce_memory_footprint_; // Heap::kReduceMemoryFootprintMask
+ bool abort_incremental_marking_; // Heap::kAbortIncrementalMarkingMask
+ bool finalize_incremental_marking_; // Heap::kFinalizeIncrementalMarkingMask
MarkingParity marking_parity_;
@@ -790,8 +790,6 @@ class MarkCompactCollector {
// candidates.
bool compacting_;
- bool was_marked_incrementally_;
-
// True if concurrent or parallel sweeping is currently in progress.
bool sweeping_in_progress_;
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | src/heap/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698