Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273613002: Revert of IWYU: 'core' target, files starting A-C. (Closed)

Created:
5 years, 4 months ago by reed2
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of IWYU: 'core' target, files starting A-C. (patchset #5 id:80001 of https://codereview.chromium.org/1265033002/ ) Reason for revert: revert to unblock DEPS roll ../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error: variable has incomplete type 'SkPath' SkPath base_path; Original issue's description: > IWYU: 'core' target, files starting A-C. > > TBR=reed@google.com > Verbal lgtm, does not change API. > > Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 TBR=reed@google.com,mtklein@google.com,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/fb8c1fcab19c99b56d2fdcf6234751d6f0465142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -221 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/BezierBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/ChartBench.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M bench/HairlinePathBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/PathBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/PathIterBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/RectoriBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/SKPBench.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/aarectmodes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/aaxfermodes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/beziers.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/bigblurs.cpp View 2 chunks +1 line, -1 line 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bitmaprecttest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/blurs.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/complexclip2.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/concavepaths.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/conicpaths.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/convexpaths.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/cubicpaths.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/degeneratesegments.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/drawable.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/dstreadshuffle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/emptypath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/filltypes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/filltypespersp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/getpostextpath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/hairlines.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/hittestpath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/linepaths.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/nested.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/pathfill.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/pathinterior.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/plus.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/poly2poly.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/quadpaths.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/samplerstress.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/shadertext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/shadertext2.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/shadows.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/skbug1719.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/smallarc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/srcmode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/stlouisarch.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/strokes.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M include/core/SkAnnotation.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkBBHFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -21 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +6 lines, -6 lines 0 comments Download
M include/core/SkColor.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/private/SkRecords.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleAAClip.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M samplecode/SampleChart.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M samplecode/SampleClip.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleClipDrawMatch.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M samplecode/SampleClock.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleDitherBitmap.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M samplecode/SampleEmptyPath.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleFilterQuality.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleIdentityScale.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleLayerMask.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SamplePathFuzz.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleShaderText.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleStringArt.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkAnnotation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBBHFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 4 chunks +12 lines, -8 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkBitmapFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapFilter.cpp View 1 chunk +10 lines, -4 lines 0 comments Download
M src/core/SkBitmapHeap.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkBlitter.h View 1 chunk +6 lines, -8 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkCachedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkCachedData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkColor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkMiniRecorder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/svg/SkSVGDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/AAClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/CanvasStateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ClipCubicTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of IWYU: 'core' target, files starting A-C.
5 years, 4 months ago (2015-08-05 01:44:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273613002/1
5 years, 4 months ago (2015-08-05 01:44:29 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 01:45:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb8c1fcab19c99b56d2fdcf6234751d6f0465142

Powered by Google App Engine
This is Rietveld 408576698