tests/RecorderTest.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecorderTest.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/RecorderTest.cpp

diff --git a/tests/RecorderTest.cpp b/tests/RecorderTest.cpp

index 829fe3e229d12c69c20957bd4e9dc081558b34d6..c41d634b440814fca69ea336ef77b34d109a8923 100644

--- a/tests/RecorderTest.cpp

+++ b/tests/RecorderTest.cpp

@@ -98,7 +98,7 @@ DEF_TEST(Recorder_drawImage_takeReference, reporter) {

SkRecorder recorder(&record, 100, 100);

// DrawImageRect is supposed to take a reference

- recorder.drawImageRect(image.get(), 0, SkRect::MakeWH(100, 100));

+ recorder.drawImageRect(image.get(), SkRect::MakeWH(100, 100), nullptr);

REPORTER_ASSERT(reporter, !image->unique());

Tally tally;