tests/RecordDrawTest.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecordDrawTest.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/RecordDrawTest.cpp

diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp

index 9bbf1d95af4b4b7bc9cbe746addf05b108a56aa0..da782966484b0066924466c84de13628327b7d5f 100644

--- a/tests/RecordDrawTest.cpp

+++ b/tests/RecordDrawTest.cpp

@@ -325,7 +325,7 @@ DEF_TEST(RecordDraw_drawImage, r){

{

SkRecord record;

SkRecorder recorder(&record, 10, 10);

- recorder.drawImageRect(image, 0, SkRect::MakeWH(10, 10));

+ recorder.drawImageRect(image, SkRect::MakeWH(10, 10), nullptr);

SkRecordDraw(record, &canvas, NULL, NULL, 0, NULL, 0);

}

REPORTER_ASSERT(r, canvas.fDrawImageRectCalled);