tests/SurfaceTest.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SurfaceTest.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SurfaceTest.cpp

diff --git a/tests/SurfaceTest.cpp b/tests/SurfaceTest.cpp

index 157ccf6c77a7d769181654d7f2f1428a4a20f334..fac283d5b13a2559d75875577361c41a75ff4086 100644

--- a/tests/SurfaceTest.cpp

+++ b/tests/SurfaceTest.cpp

@@ -705,7 +705,7 @@ static void TestSurfaceCopyOnWrite(skiatest::Reporter* reporter, SurfaceType sur

EXPECT_COPY_ON_WRITE(drawRRect(testRRect, testPaint))

EXPECT_COPY_ON_WRITE(drawPath(testPath, testPaint))

EXPECT_COPY_ON_WRITE(drawBitmap(testBitmap, 0, 0))

- EXPECT_COPY_ON_WRITE(drawBitmapRect(testBitmap, testRect))

+ EXPECT_COPY_ON_WRITE(drawBitmapRect(testBitmap, testRect, nullptr))

EXPECT_COPY_ON_WRITE(drawBitmapNine(testBitmap, testIRect, testRect, NULL))

EXPECT_COPY_ON_WRITE(drawSprite(testBitmap, 0, 0, NULL))

EXPECT_COPY_ON_WRITE(drawText(testText.c_str(), testText.size(), 0, 1, testPaint))

« src/utils/SkLua.cpp ('K') | « tests/RecorderTest.cpp ('k') | no next file » | no next file with comments »