Allow networkingPrivate to request configure UI

Allow networkingPrivate to request configure UI

Currently if networkingPrivate attempts to connect
to an unconfigured network, the request fails and the
UI is expected to handle configuraiton.

Until network configuration is fully integrated into the
new Settings UI, we need Chrome to handle the configuration
UI.

This CL:
* Adds HandleConnectFailed to NetworkingPrivateDelegate::UIDelegate
* Suppresses a redundant notification when a connect to an
  unconfigured network fails.
Also:
* Updates the logging in the notification code
* Handles "expected" errors in network_summary.js to avoid "unhandled lastError" messages when requesting a connect to an unconfigured network.

BUG=515987
Committed: https://crrev.com/1d031671711c66cc5d846731794f5aa1de23d905
Cr-Commit-Position: refs/heads/master@{#342391}

[stevenjb, 2015-08-04 19:56:44]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, pneubeck@chromium.org

[pneubeck (no reviews), 2015-08-06 09:52:01]

a few comments

lgtm

https://codereview.chromium.org/1272003002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_delegate.h
(right):

https://codereview.chromium.org/1272003002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_delegate.h:93: //
Possibly handle a connection failure, e.g. by showing the configuration
as commented in network_connect.h, please consider giving this function a name
and comment according to what it does and not according to when it is called.

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_connect.h (right):

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_connect.h:69: virtual bool HandleConnectFailed(const
std::string& service_path,
if possible, please consider giving this function a name and comment according
to what it does and not according to when it is called (like the second sentence
in the comment).
That would make it much easier to read and to understand what's going on.

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_state_notifier.cc (right):

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_state_notifier.cc:386: // Connect failure on non
connectable network with with no additional
s/with with/with/

[stevenjb, 2015-08-07 17:39:38]

https://codereview.chromium.org/1272003002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_delegate.h
(right):

https://codereview.chromium.org/1272003002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_delegate.h:93: //
Possibly handle a connection failure, e.g. by showing the configuration
On 2015/08/06 09:52:01, pneubeck wrote:
> as commented in network_connect.h, please consider giving this function a name
> and comment according to what it does and not according to when it is called.

Here at least I wanted to keep it general purpose since it is a delegate
interface what it does might change.

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_connect.h (right):

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_connect.h:69: virtual bool HandleConnectFailed(const
std::string& service_path,
On 2015/08/06 09:52:01, pneubeck wrote:
> if possible, please consider giving this function a name and comment according
> to what it does and not according to when it is called (like the second
sentence
> in the comment).
> That would make it much easier to read and to understand what's going on.

Renamed MaybeShowConfigureUI.

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_state_notifier.cc (right):

https://codereview.chromium.org/1272003002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_state_notifier.cc:386: // Connect failure on non
connectable network with with no additional
On 2015/08/06 09:52:01, pneubeck wrote:
> s/with with/with/

Done.

[stevenjb, 2015-08-07 17:39:41]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-08-07 17:39:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
pneubeck@chromium.org
Link to the patchset: https://codereview.chromium.org/1272003002/#ps40001
(title: "Feedback")

[commit-bot: I haz the power, 2015-08-07 17:40:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272003002/40001

[commit-bot: I haz the power, 2015-08-07 18:36:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-07 18:37:04]

Patchset 3 (id:??) landed as
https://crrev.com/1d031671711c66cc5d846731794f5aa1de23d905
Cr-Commit-Position: refs/heads/master@{#342391}