Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2488)

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary.js

Issue 1272003002: Allow networkingPrivate to request configure UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_summary.js
diff --git a/chrome/browser/resources/settings/internet_page/network_summary.js b/chrome/browser/resources/settings/internet_page/network_summary.js
index 8425177efe9d4993b0b5e9600898f66c8d9f41f1..636d746e66e3de836aca8801cf4af03fa1cd65ef 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary.js
+++ b/chrome/browser/resources/settings/internet_page/network_summary.js
@@ -208,6 +208,13 @@ Polymer({
chrome.networkingPrivate.getState(
id,
function(state) {
+ if (chrome.runtime.lastError) {
+ if (chrome.runtime.lastError != 'Error.NetworkUnavailable') {
+ console.error('Unexpected networkingPrivate.getState error:',
+ chrome.runtime.lastError);
+ }
+ return;
+ }
// Async call, ensure id still exists.
if (!this.networkIds_[id])
return;
@@ -228,7 +235,13 @@ Polymer({
* @private
*/
connectToNetwork_: function(state) {
- chrome.networkingPrivate.startConnect(state.GUID);
+ chrome.networkingPrivate.startConnect(state.GUID, function() {
+ if (chrome.runtime.lastError &&
+ chrome.runtime.lastError != 'connecting') {
+ console.error('Unexpected networkingPrivate.startConnect error:',
+ chrome.runtime.lastError);
+ }
+ });
},
/**

Powered by Google App Engine
This is Rietveld 408576698