Add cr-network-select element for selecting a Chrome OS network

Add cr-network-select element for selecting a Chrome OS network

The purpose of this CL is to provide a network select UI for
pages other than Settings, specifically the OOBE Ui.

This CL:
* Moves cr_network_icon and cr_onc_types to cr_elements/network
* Moves cr_network_list and cr_network_list_item to cr_elements/network
* Introduces a cr_network_select wrapper to cr_elements/network
  The wrapper implements the networkingPrivate calls required to
  connect to a network or show the configure UI for a network.
* Adds cr_network_select to chrome://network to demonstrate it
  and provide convenient access within that page while testing.

BUG=515987
Committed: https://crrev.com/be74f2657e23e6ad6717c33e930c0e2c7289445e
Cr-Commit-Position: refs/heads/master@{#342705}

[stevenjb, 2015-08-07 17:57:17]

stevenjb@chromium.org changed reviewers:
+ jhawkins@chromium.org, michaelpg@chromium.org

[stevenjb, 2015-08-07 17:57:18]

michaelpg@ as primary reviewer

jhawkins@ - I know you had concerns about including networking elements in
cr_elements. I looked into adding another location for these but felt that the
extra overhead of serving elements from an additional location was not worth it.
Instead I created a cr_elements/network subdirectory, moved the existing
cr_network_icon and cr_onc_types files there, and only added the elements that
will actually be used in the OOBE UI. LMKWYT.

[michaelpg, 2015-08-10 07:35:03]

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/network_ui/network_ui.css (right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/network_ui/network_ui.css:24: align-items:
center;
this doesn't do anything now (I think)

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:7:
<link rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_onc_types.html">
nit: alphabetize

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/network_ui.cc (right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/network_ui.cc:177:
html->AddLocalizedString("Disabled", IDS_OPTIONS_SETTINGS_NETWORK_DISABLED);
"disabled"?

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:168:
html_source->AddLocalizedString("Disabled",
ditto

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/demo_element.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/demo_element.html:8: <link rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_icon.html">
nit: alpha

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list.html:4: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_list_item.html">
nit: alpha

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.html
(right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_onc_types.html">
nit: alpha

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js
(right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:14: *
Performs argument substitution, replacing %1, %2, etc in 'text' with
% -> $

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:17: * @param
{?Array<string>} args The arguments to replace %1, %2, etc with.
ditto

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:21: if
(loadTimeData && loadTimeData.data_) {
nit: no brackets

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/cr_collapse/cr_collapse.html">
collapse -> expand_button

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:4: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_list.html">
nit: alpha

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:8: <!-- <link
rel="import" type="css" href="cr_network_select.css"> -->
rm

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:12:
<cr-expand-button toggles hidden$=[["!expandable"]]
swap [[]] and ""

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:15:
<cr-network-list-item hidden$=[["!showActive"]]
same

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:23:
</template>
</div>

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:6: *
@fileoverview Polymer element wrapping cr-network-list including th
+e

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:16: properties:
{
expandable, showActive, maxHeight?

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:84:
this.activeNetworkState = (states && states.length && states[0]) || null;
no need to check states.length

also, shouldn't |states| always be defined (and an array)?

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:100:
console.error('networkingPrivate.startConnect error:', lastError);
indent

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements_resources.grdp:105: <structure
name="IDR_CR_ELEMENTS_1_0_CR_NETWORK_ONC_TYPES_HTML"
not sure if we should alphabetize by name or filename... but let's pick one

[michaelpg, 2015-08-10 17:42:14]

lgtm pending import fix

https://codereview.chromium.org/1277223002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html (right):

https://codereview.chromium.org/1277223002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/cr_expand/cr_expand.html">
cr_expand_button, there is no cr_expand

[James Hawkins, 2015-08-10 17:45:50]

I still feel like there's probably a better place for these types of shared
elements, but I don't know what it is, and I'd rather we be flexible as the
requirements change, so LGTM.

[stevenjb, 2015-08-10 19:19:48]

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/network_ui/network_ui.css (right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/network_ui/network_ui.css:24: align-items:
center;
On 2015/08/10 07:35:03, michaelpg wrote:
> this doesn't do anything now (I think)

Removed the div.

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:7:
<link rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_onc_types.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/network_ui.cc (right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/network_ui.cc:177:
html->AddLocalizedString("Disabled", IDS_OPTIONS_SETTINGS_NETWORK_DISABLED);
On 2015/08/10 07:35:03, michaelpg wrote:
> "disabled"?

-> networkDisabled

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1277223002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:168:
html_source->AddLocalizedString("Disabled",
On 2015/08/10 07:35:03, michaelpg wrote:
> ditto

-> networkDisabled

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/demo_element.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/demo_element.html:8: <link rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_icon.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: alpha

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list.html:4: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_list_item.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: alpha

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.html
(right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_onc_types.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: alpha

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js
(right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:14: *
Performs argument substitution, replacing %1, %2, etc in 'text' with
On 2015/08/10 07:35:03, michaelpg wrote:
> % -> $

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:17: * @param
{?Array<string>} args The arguments to replace %1, %2, etc with.
On 2015/08/10 07:35:03, michaelpg wrote:
> ditto

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js:21: if
(loadTimeData && loadTimeData.data_) {
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: no brackets

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/cr_collapse/cr_collapse.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> collapse -> expand_button

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:4: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/network/cr_network_list.html">
On 2015/08/10 07:35:03, michaelpg wrote:
> nit: alpha

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:8: <!-- <link
rel="import" type="css" href="cr_network_select.css"> -->
On 2015/08/10 07:35:03, michaelpg wrote:
> rm

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:12:
<cr-expand-button toggles hidden$=[["!expandable"]]
On 2015/08/10 07:35:03, michaelpg wrote:
> swap [[]] and ""

Oops. Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:15:
<cr-network-list-item hidden$=[["!showActive"]]
On 2015/08/10 07:35:03, michaelpg wrote:
> same

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:23:
</template>
On 2015/08/10 07:35:03, michaelpg wrote:
> </div>

Sometimes I really hate HTML's "try to make it work" parsing.
Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:6: *
@fileoverview Polymer element wrapping cr-network-list including th
On 2015/08/10 07:35:03, michaelpg wrote:
> +e

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:16: properties:
{
On 2015/08/10 07:35:03, michaelpg wrote:
> expandable, showActive, maxHeight?

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:84:
this.activeNetworkState = (states && states.length && states[0]) || null;
On 2015/08/10 07:35:03, michaelpg wrote:
> no need to check states.length
> 
> also, shouldn't |states| always be defined (and an array)?

Yes. Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js:100:
console.error('networkingPrivate.startConnect error:', lastError);
On 2015/08/10 07:35:03, michaelpg wrote:
> indent

Done.

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/1277223002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements_resources.grdp:105: <structure
name="IDR_CR_ELEMENTS_1_0_CR_NETWORK_ONC_TYPES_HTML"
On 2015/08/10 07:35:03, michaelpg wrote:
> not sure if we should alphabetize by name or filename... but let's pick one

I think actually we decided the subdirctory name was unnecessary; removed
_NETWORK.

https://codereview.chromium.org/1277223002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html (right):

https://codereview.chromium.org/1277223002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html:2: <link
rel="import"
href="chrome://resources/cr_elements/v1_0/cr_expand/cr_expand.html">
On 2015/08/10 17:42:14, michaelpg wrote:
> cr_expand_button, there is no cr_expand

Done.

[stevenjb, 2015-08-10 19:19:58]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-08-10 19:19:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1277223002/#ps40001
(title: "Move cr_network_icon images, misc fixes")

[commit-bot: I haz the power, 2015-08-10 19:20:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277223002/40001

[commit-bot: I haz the power, 2015-08-10 19:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 19:34:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[stevenjb, 2015-08-10 19:45:49]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-08-10 19:45:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1277223002/#ps60001
(title: "Compile fix")

[commit-bot: I haz the power, 2015-08-10 19:46:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277223002/60001

[commit-bot: I haz the power, 2015-08-10 22:06:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-10 22:06:55]

Patchset 4 (id:??) landed as
https://crrev.com/be74f2657e23e6ad6717c33e930c0e2c7289445e
Cr-Commit-Position: refs/heads/master@{#342705}