Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1271873002: Break LCD and Bitmap text dependency on hardcoded atlas values (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -36 lines) Patch
M include/core/SkFloatingPoint.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/GrFontAtlasSizes.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 chunks +18 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 5 chunks +38 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-03 19:56:33 UTC) #2
bsalomon
https://codereview.chromium.org/1271873002/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.cpp File src/gpu/effects/GrDistanceFieldGeoProc.cpp (right): https://codereview.chromium.org/1271873002/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.cpp#newcode84 src/gpu/effects/GrDistanceFieldGeoProc.cpp:84: SkScalar recipeWidth = 1.0f / atlas->width(); recipe width! sounds ...
5 years, 4 months ago (2015-08-03 21:02:34 UTC) #3
jvanverth1
LGTM too
5 years, 4 months ago (2015-08-03 21:15:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271873002/20001
5 years, 4 months ago (2015-08-04 16:29:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/846b022f6b469cfde285372f26e0d5c593d122ac
5 years, 4 months ago (2015-08-04 16:40:08 UTC) #8
joshualitt
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1271163003/ by joshualitt@google.com. ...
5 years, 4 months ago (2015-08-05 13:45:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271873002/20001
5 years, 4 months ago (2015-08-07 16:48:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271873002/20001
5 years, 4 months ago (2015-08-07 16:51:04 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 16:55:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/922c8b13c512c3287509936795735c1b31bedba9

Powered by Google App Engine
This is Rietveld 408576698